Repository navigation
Show tasks immediately upon creation with optimistic UI - #3327
Open
corbin-auriti wants to merge 1 commit into
Open
corbin-auriti wants to merge 1 commit into
corbin-auriti wants to merge 1 commit into
Conversation
Tasks now appear in the UI right away while the CalDAV request to the server is still running. On success the DAV object is attached through the store's reactive proxy and any updates queued during the request are flushed. On failure the optimistic state is rolled back and an error is shown. The same treatment is applied to duplicating tasks. This makes creating and duplicating tasks feel instant, especially on slower servers or remote connections. Signed-off-by: Corbin Auriti <corbin@no-bs.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creating a task (or duplicating one) currently waits for the CalDAV request to finish before the task appears in the UI, which makes adding tasks feel sluggish, especially on remote or slower servers.
This PR makes task creation and duplication optimistic:
Only
src/store/tasks.jsis touched; the diff applies cleanly on currentmain.Testing
Signed-off-by: Corbin Auriti corbin@no-bs.ca