Skip to content

feat(nc_model): Automatically save output attachments in the user's assistant folder - #316

Merged
marcelklehr merged 1 commit into
mainfrom
feat/auto-save-output-attachments
Nov 11, 2026
Merged

marcelklehr merged 1 commit into
mainfrom
feat/auto-save-output-attachments

Conversation

@marcelklehr

@marcelklehr marcelklehr commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

to make them available for tool calls

this is part of a pack of PRs:

end to end test with integration_openai:

before after
Image Image

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

…ssistant folder

to make them available for tool calls

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@WSHAPER

WSHAPER commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The fallback and error handling look solid, and the tests cover the new paths well.

The streaming path (_astream with attachments) has the same logic but no test coverage, and that is the default path for Assistant, worth an addition? Wdyt?

@WSHAPER WSHAPER left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on thread 👆

@marcelklehr
marcelklehr marked this pull request as ready for review November 11, 2026 07:21
@marcelklehr

Copy link
Copy Markdown
Member Author

Let's keep this self-contained

@kyteinsky kyteinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@WSHAPER WSHAPER left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marcelklehr
marcelklehr merged commit 4ceb7d4 into main Nov 11, 2026
8 checks passed
@marcelklehr
marcelklehr deleted the feat/auto-save-output-attachments branch November 11, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants