Skip to content

build: exclude development files from app releases - #1204

Open
skjnldsv wants to merge 1 commit into
mainfrom
fix/nextcloudignore
Open

skjnldsv wants to merge 1 commit into
mainfrom
fix/nextcloudignore

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

The release build still has to delete these development files itself because this app's .nextcloudignore doesn't list them. nextcloud-releases/server#137 now reports that per app. This adds them, anchored to the app root and sorted like recommendations' file. composer.json, package.json and their lock files stay in the release on purpose, for traceability.

It also stops removing composer.json and package.json. Existing entries are now anchored to the app root, which doesn't change what ships. It also drops entries for files that no longer exist on any branch. It also ignores dev files found in this repo: /APPS.md.

I checked it with git ls-files -ci --exclude-from=.nextcloudignore on main, stable35, stable34 and stable33: no development file is left at the root, and nothing else changes in what ships.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

List every development file the release tooling still has to remove, anchored to the app root and sorted, so the app's own .nextcloudignore covers them. composer.json, package.json and their lock files stay in the release for traceability.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv self-assigned this Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .nextcloudignore list now root-anchors several retained patterns and adds exclusions for project configuration, documentation, build outputs, tests, and vendor tooling. It removes exclusions for several configuration files and package manifests. The tests pattern is now /tests.

Merge Risk: Minimal · up to 03723

This change only adjusts which development files are left out of release packages, and nothing in it affects runtime behavior. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: development files are now excluded from app releases via .nextcloudignore. It uses the conventional 'build:' prefix and is concise. The change set matches the title, s…
Description check Passed The description states the purpose: the release build does not remove these development files because the app's .nextcloudignore omits them. It names the added entries, the root anchoring, the retaine…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: development files are now excluded from app releases via .nextcloudignore. It uses the conventional 'build:' prefix and is concise. The change set matches the title, since the raw summary describes new root-anchored exclusions for editor, build, documentation, test, and vendor files in .nextcloudignore.

Full details: Description check

Explanation

The description states the purpose: the release build does not remove these development files because the app's .nextcloudignore omits them. It names the added entries, the root anchoring, the retained composer.json, package.json and lock files, the removed stale entries, and the verification commands. This matches the changeset described in the raw summary and objectives.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 231166e4-20ba-4e22-9b61-7b9069292eb8
Commits

Reviewing files that changed from the base of the PR and between bd4f774 and 0372385.

Files selected for processing: 1

  • .nextcloudignore

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@skjnldsv
skjnldsv enabled auto-merge November 13, 2026 04:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant