Repository navigation
[stable34] fix: apply headers_to_exclude given in info.xml - #1190
Merged
Merged
Conversation
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A route's
headers_to_excludecomes from info.xml as a JSON string, such as["X-Foo"], butregisterExAppRoutesonly kept arrays, so it was stored as[]and the ExApp proxy did not remove those headers. It is now decoded likebruteforce_protection, as on main since #885. Existing routes get the list when the ExApp is updated to a new version or registered again.The test checks the stored value for an info.xml string and a
--json-infoarray.