Repository navigation
Conversation
Contributor
|
@suhaibmujahid Bumping this one, I think it might have fallen off the radar. |
suhaibmujahid
approved these changes
Nov 12, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
@OrlaM thank you for the ping!
@Foxbolts LGTM! Thank you! Could you please rebase?
@ayoubdiourin7 please do your pass and merge when it is ready.
| ) | ||
|
|
||
|
|
||
| class AddInlineCommentsHandler: |
Member
There was a problem hiding this comment.
When there are normal comments and inline comments, we might want to merge them together to be submitted at once so we trigger a single notification email. If it not a simple change, please file a follow-up issue for that and we could do it later.
Contributor
Author
There was a problem hiding this comment.
🫡 general and inline comments for the same PR are now combined into one review when applied together. FYI standalone PR comments still work as before
Foxbolts
force-pushed
the
ml/hackbot-github-comments
branch
from
November 12, 2026 21:10
63daf2a to
1606e46
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7056
Description
Add
github.add_commentandgithub.add_inline_commentsto the hackbot runtime, with matching handlers inhackbot-apiAgents record proposed comments during a run, and
hackbot-apiposts them as the GitHub App when the actions are applied. Standalone general comments go in the PR conversation. When general and inline comments for the same PR are applied together, they are combined into one review.Notes
pull_requests: write.