Add the perf-triage agent by pslawless · Pull Request #7349 · mozilla/bugbug

pslawless · 2026-10-29T19:52:08Z

Adds perf-triage, a Hackbot agent that rates a Firefox performance bug's Performance Impact with the Performance Impact Calculator and writes the result to the bug. A companion bugbot rule (mozilla/bugbot, separate PR) triggers it when cf_performance_impact is set to ? or a bug lands in Core :: Performance: General.

What it writes

Bug state	Writes
Unrated (`---`/`?`)	One comment; `cf_performance_impact`; the calculator's keywords (add only); a needinfo to the perf reviewer on a `high` rating
Rated by a person	One comment, only if the agent disagrees. Never touches the field

Writes are recorded during the run and applied afterwards by hackbot-api. A run applies unattended only when the calculator, re-scored over every input the bug leaves open and every platform choice, stays in one band. Otherwise it waits for a person. hooks.py refuses any other write as it is recorded.

Deployment prerequisites

The hackbot Bugzilla account needs membership in the perf-triage-team Bugzilla group, with edit rights to cf_performance_impact. Without the membership, every update on an unrated bug is rejected. We'll confirm with one real write on a test bug after the first deploy.
Deploy the agent before the bugbot rule is enabled. The rule's first run uses --backlog; after that it looks back one day.
Open: the agents.json entry in mozilla/webservices-infra. Who adds it: the hackbot team or the agent author?

🤖 Generated with Claude Code

evgenyrp · 2026-11-05T19:36:27Z

@pslawless I'm reviewing the overall agent, but can we add someone else who is familiar with perf-triage to review the relevant pieces?

suhaibmujahid · 2026-11-05T16:42:28Z

+and the refused action never lands. Pattern from frontend-triage's hooks.py.
+"""
+
+from __future__ import annotations


We already require python 3.14, so no need for __future__.

suhaibmujahid · 2026-11-05T16:56:17Z

+    recorder.record(
+        "bugzilla.add_comment",
+        {"bug_id": bug_id, "text": text, "is_private": False},
+        reasoning=f"Performance triage: {result.impact} ({result.score})",
+    )


We could use add_comment() here instead of using recorder.record(), so that we do not need to add the footer manually and things stay constant.

bugbug/libs/hackbot-runtime/hackbot_runtime/actions/bugzilla.py

Line 67 in b2d3a88

async def add_comment(

suhaibmujahid · 2026-11-05T16:57:26Z

+        recorder.record(
+            "bugzilla.update_bug",
+            {"bug_id": bug_id, "changes": changes},
+            reasoning="Set from the triage calculator's rating and keywords",
+        )


We could use update_bug() here instead of using recorder.record().

bugbug/libs/hackbot-runtime/hackbot_runtime/actions/bugzilla.py

Line 28 in b2d3a88

async def update_bug(

suhaibmujahid · 2026-11-05T16:58:21Z

+REACTION_LINE = (
+    "If you'd like to provide feedback on this comment, please use the 👍 or 👎 "
+    "reaction."
+)


I would avoid adding this manually.

suhaibmujahid · 2026-11-05T17:00:05Z

+FEEDBACK_TAGS = (
+    "If you want to categorize your feedback you can add one of the following "
+    "tags: perf-triage-{wrong-impact, wrong-component, wrong-cause, "
+    "wrong-severity, hallucination, not-perf}."
+)


This can be added using a hook, example:

bugbug/agents/frontend-triage/hackbot_agents/frontend_triage/agent.py

Lines 87 to 98 in b2d3a88

def feedback_tags_hook(action: dict) -> None:

"""Offer the feedback tags and the patch request below the runtime's footer.

The patch request takes a blank line: the comment is Markdown, where a lone

newline would fold it onto the end of the tag list.

"""

params = action.get("params")

if not isinstance(params, dict):

return

text = params.get("text")

if isinstance(text, str):

params["text"] = f"{text.rstrip()}\n{_FEEDBACK_TAGS}\n\n{_PATCH_REQUEST}"

suhaibmujahid · 2026-11-05T19:51:43Z

@@ -0,0 +1,30 @@
+[project]
+name = "performance-tools"


The code in libs/performance-tools would be a natural fit as part of the agent itself rather than as a standalone library. I understand the goal is to make it reusable for future performance-related agents. Since this is a single uv workspace, agents can easily import modules from one another, and any common tools can be extracted into a shared library later, once the need is clear.

Folded into the agent package in e5be53a. If a second perf agent needs it, we'll extract a shared library then.

suhaibmujahid · 2026-11-05T19:53:19Z

+# Local agent run output
+artifacts/


They should be in ~/hackbot/artifacts, so this should not be needed any way.

evgenyrp · 2026-11-05T19:59:58Z

@pslawless I'm reviewing the overall agent, but can we add someone else who is familiar with perf-triage to review the relevant pieces?

I'm passing it to @suhaibmujahid as he already started reviewing

pslawless · 2026-11-06T22:05:42Z

@suhaibmujahid - I've addressed your comments so far. And I asked @Bas-moz to review the triage parts (I didn't see a way to add him as a reviewer on the PR though).

suhaibmujahid · 2026-11-06T22:35:52Z

I didn't see a way to add him as a reviewer on the PR though

@pslawless I created a new team, @mozilla/hackbot-performance, with write permission to the repo. I added @Bas-moz to it, so he can now be requested as a reviewer on PRs. You can manage the team, so please remove me from it once you’ve accepted the invite.

Related: please add @mozilla/hackbot-performance as the agent code owner in .github/CODEOWNERS, so you can land PRs independently going forward.

Bas-moz · 2026-11-11T13:47:40Z

+    "duckduckgo.com",
+    "amazon.de"
+   ],
+   "common": [


Is this still used? It seems to me like the code just looks at the rank now.

The code only reads rank. tier_examples is a human-readable sample that the upstream generator (build_top_sites.py in performance-triage-calculator) writes, and the file is vendored verbatim. I'll drop it upstream rather than edit the vendored copy.

Bas-moz · 2026-11-11T14:11:41Z

@@ -0,0 +1,62 @@
+You are a Firefox page-load performance reproduction agent. You investigate


Do we intend to limit the scope of the agent to pageload? It feels like the rest of this patch permits a broader scope.

Runs the triage-perf-bug skill from mozilla/performance-triage-calculator in agent mode and returns its Performance Impact rating, severity, the inputs the bug did not establish, the related bugs it took inputs from, and an optional profile finding. The stability check re-scores the vendored calculator over every value of the unestablished inputs, plus platforms; a rating is confident only when the band never changes. Reproducibility is out of scope for this phase and is never varied. blind.py lets the broker hide a bug's engineer triage (BLIND_BUG_ID), for evaluating the agent against ratings people already made. The skill, the profiler-analysis skill and perf_triage.py are vendored verbatim (see skills/PINNED.md) and excluded from pre-commit so they stay byte-identical to their pinned revisions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Triages a performance bug with libs/performance-tools and records a comment plus cf_performance_impact and keywords. Writes auto-apply only when the rating is stable; otherwise they are held for review. On a bug a person already rated it comments only when it disagrees and never changes the field. A high rating needinfos the performance triage reviewer, and every comment names them as the contact for disagreements. Fails closed when the bug lookup fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Cleaned up README

- Fold libs/performance-tools into the agent package; extract a shared library later if a second agent needs it. - Record the comment and bug change through hackbot_runtime's add_comment and update_bug, so the runtime supplies the reaction footer. - Append the feedback tags with an add_comment hook, as frontend-triage does. - Drop from __future__ imports (Python 3.14 is required). - Drop the artifacts/ ignore; runs write to ~/hackbot/artifacts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The shared system prompt was perf-repro's: it told every triage run it was a page-load reproduction agent, to measure and not diagnose, and to triage out jank, memory and startup bugs. Keep only the generic rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Picks up the per-bug profiler-cli session (39acdfa), a symlink note in Step 0 (ec4f454), and drops the unused tier_examples block from top_sites.json (0674246, raised in review). perf_triage.py, criteria.md and the two scripts are byte-identical to c78430d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Matches mozilla#7466: the release flow bumps agents/<name>/VERSION, and it fails on an agent without one. Also require Python 3.14, as the other agents do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

pslawless · 2026-11-12T21:53:38Z

Hi @suhaibmujahid, just wanted to check in on this PR. Looks like Bas has accepted the triage related parts. Is there anything else you need from me? (I'm excited to get this agent running :)

pslawless requested a review from a team as a code owner October 29, 2026 19:52

pslawless mentioned this pull request Oct 29, 2026

Add perf_triage: send bugs waiting for performance triage to hackbot's perf-triage agent mozilla/bugbot#3091

Open

2 of 3 tasks

pslawless force-pushed the perf-triage branch 4 times, most recently from 366f247 to 9ddda21 Compare October 31, 2026 00:04

evgenyrp self-requested a review November 5, 2026 18:27

suhaibmujahid reviewed Nov 5, 2026

View reviewed changes

evgenyrp removed their request for review November 5, 2026 19:58

suhaibmujahid requested a review from Bas-moz November 6, 2026 22:29

Bas-moz reviewed Nov 11, 2026

View reviewed changes

Bas-moz approved these changes Nov 11, 2026

View reviewed changes

pslawless and others added 9 commits November 12, 2026 12:20

hackbot-api: register perf-triage with consent-gated auto-apply

ac54217

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Update README.md

c15b868

Cleaned up README

perf-triage: add @mozilla/hackbot-performance as code owner

b6fa2e5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

perf-triage: read the version from a VERSION file

fcf0d75

Matches mozilla#7466: the release flow bumps agents/<name>/VERSION, and it fails on an agent without one. Also require Python 3.14, as the other agents do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

pslawless force-pushed the perf-triage branch from 935ddff to fcf0d75 Compare November 12, 2026 20:28

	def feedback_tags_hook(action: dict) -> None:
	"""Offer the feedback tags and the patch request below the runtime's footer.

	The patch request takes a blank line: the comment is Markdown, where a lone
	newline would fold it onto the end of the tag list.
	"""
	params = action.get("params")
	if not isinstance(params, dict):
	return
	text = params.get("text")
	if isinstance(text, str):
	params["text"] = f"{text.rstrip()}\n{_FEEDBACK_TAGS}\n\n{_PATCH_REQUEST}"

		@@ -0,0 +1,62 @@
		You are a Firefox page-load performance reproduction agent. You investigate

Conversation

pslawless commented Oct 29, 2026

What it writes

Deployment prerequisites

Uh oh!

evgenyrp commented Nov 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgenyrp commented Nov 5, 2026

Uh oh!

pslawless commented Nov 6, 2026

Uh oh!

suhaibmujahid commented Nov 6, 2026

Uh oh!

Bas-moz Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pslawless commented Nov 12, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bas-moz Nov 11, 2026 •

edited

Loading