Repository navigation
[Docs] Add AGENTS.md - #634
Open
chr-hertel wants to merge 1 commit into
Open
chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 27, 2026 21:10
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
AGENTS.md points OAuth work to the wrong namespace and incorrectly claims that supported modern-only result fields are not modeled.
2 open issues
What changed in this PR
Adds repository guidance for AI coding agents working on the PHP MCP SDK. This documentation-only change covers development workflows, architecture, and contribution conventions.
Changes:
- Documents setup, testing, analysis, and documentation commands.
- Maps server, client, and shared protocol components across both protocol eras.
- Defines coding, specification-reference, and review communication guidelines.
| File | Description |
|---|---|
| AGENTS.md | Adds commands, architecture guidance, and contribution conventions for AI coding agents. |
Review effort: Balanced
Comment on lines
+49
to
+50
| `Server\Wire\Rev2025Codec`/`Rev2026Codec` translate the revision-neutral result model into each era's wire shape, so | ||
| modern-only fields (`resultType`, caching hints, …) are stamped at the edge, not modelled on `Schema\Result\*`. |
| fiber with the client's answer. Request ids to the client are UUIDs, matched per fiber, so concurrent requests of one | ||
| session don't cross. | ||
| - `Server\Session\*`: session stores (in-memory, file, PSR-16) and optional per-session locks. | ||
| - `Server\Authorization\*`: resource-server-only OAuth (ADR 0001/0002 in `adr/`) — token validation, scope policy, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
AGENTS.mdwith commands, architecture overview and coding conventions for AI coding agents.🤖 Generated with Claude Code