Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,19 @@ def connect(self):
schema = self.connection_args.get("schema")
if schema:
with self.connection.cursor() as cur:
cur.execute("SELECT 1 FROM pg_namespace WHERE nspname = %s;", (schema,))
if cur.fetchone() is None:
raise psycopg.errors.InvalidSchemaName(
f'Schema "{schema}" does not exist in database "{self.database}". '
"Schema names are case-sensitive."
)
cur.execute(f'SET search_path TO "{schema}", public;')
self.connection.commit()
return self.connection
except psycopg.Error as e:
logger.error(f"Error connecting to PostgreSQL {self.database}, {e}!")
if self.is_connected:
self.connection.close()
self.is_connected = False
raise

Expand Down
28 changes: 27 additions & 1 deletion tests/unit/handlers/test_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,35 @@ def test_connect_with_schema_sets_search_path_after_connection(self):
self.assertTrue(self.handler.is_connected)
self.assertIsNotNone(connection)

mock_cursor.execute.assert_called_once_with('SET search_path TO "my_schema", public;')
mock_cursor.execute.assert_called_with('SET search_path TO "my_schema", public;')
self.mock_connect.return_value.commit.assert_called_once()

def test_connect_with_missing_schema_fails(self):
"""
Tests that a schema that does not exist (for example, wrong case) fails the connection
instead of silently falling back to the public schema.
"""
self.tearDown()
self.setUp()
self.handler.connection_args["schema"] = "sales"

mock_cursor = MockCursorContextManager()
mock_cursor.fetchone = MagicMock(return_value=None)
mock_conn = self.mock_connect.return_value
mock_conn.cursor.return_value = mock_cursor

with self.assertRaises(psycopg.errors.InvalidSchemaName) as ctx:
self.handler.connect()

self.assertIn('Schema "sales" does not exist', str(ctx.exception))
mock_cursor.execute.assert_called_once_with("SELECT 1 FROM pg_namespace WHERE nspname = %s;", ("sales",))
self.assertFalse(self.handler.is_connected)
mock_conn.close.assert_called_once()

response = self.handler.check_connection()
self.assertFalse(response.success)
self.assertIn('Schema "sales" does not exist', response.error_message)

def test_make_connection_args_applies_overrides(self):
handler = self.handler
handler.connection_args = OrderedDict(
Expand Down
Loading