Repository navigation
fix(sync): do not log CancelledError for pending handlers on exit - #3267
Open
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Open
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Conversation
Exiting sync_playwright() cancels pending tasks in the loop it owns. The done callback that reports handler errors called Future.exception() on the cancelled future, which raises CancelledError and made asyncio log it. Fixes: microsoft/playwright#43463
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
October 16, 2026 20:07
Yury Semikhatsky (yury-s)
requested review from
Devin Rousso (dcrousso),
Dmitry Gozman (dgozman) and
Pavel Feldman (pavelfeldman)
and removed request for
Pavel Feldman (pavelfeldman)
October 16, 2026 20:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_playwright()cancels the pending tasks in the loop it owns. The done callback attached to event handler tasks calledFuture.exception()on the cancelled future, which raisesCancelledError, so asyncio logged "Exception in callback" for a route handler that was still waiting.Fixes microsoft/playwright#43463