Repository navigation
lsh: Fix PowerShell commands and operators matching keyword rules - #999
Open
Jae Birdsall (jaeminbird) wants to merge 1 commit into
Open
Jae Birdsall (jaeminbird) wants to merge 1 commit into
Jae Birdsall (jaeminbird) wants to merge 1 commit into
Conversation
Commands like ForEach-Object, Format-Table or Invoke-WebRequest were matched by the keyword rules before the command rule, so they were highlighted partially as a keyword or not at all. The same happened to the "in" of the -in operator. Match commands and -operators before keywords.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyword rules ran before the command rule, so cmdlets whose verb starts with a keyword were mis-highlighted:
ForEach-ObjectshowedForEachas a keyword, andFormat-Table,Invoke-WebRequestandInstall-Modulegot no highlight at all. Theinof-inwas also highlighted as a keyword.This matches
Verb-Nouncommands and-operator/-Parametertokens before the keyword rules.lsh renderof the existingpowershell.ps1sample is byte-identical before and after.assets/highlighting-tests/powershell.ps1.cargo test --workspaceandclippy -D warningspass.