Repository navigation
profiles: Standardize scalar parameter names - #824
Merged
Merged
Conversation
Use consistent Count and IterationCount suffixes across workload profiles, executors, monitors, tests, and documentation. This keeps profile overrides aligned with their implementation properties and execution paths.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename per-thread, per-port, and minimum-iteration parameters so internal profiles can use the same scalar count conventions.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bryan DeYoung (brdeyo)
requested changes
Oct 13, 2026
added 3 commits
October 13, 2026 15:33
Add an ordered multi-key GetValue overload so renamed profile parameters can retain compatibility with legacy customer profiles.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept the original Redis instance and SPEC CPU count parameter names as aliases while preferring the standardized names when both are supplied.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept the original networking, monitor iteration, and minimum iteration names used by internal and customer profiles while preferring standardized count names.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bryan DeYoung (brdeyo)
approved these changes
Oct 15, 2026
Bryan DeYoung (brdeyo)
approved these changes
Oct 15, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AlexWFMS
force-pushed
the
agents/ai-profile-consistency-update
branch
from
October 15, 2026 16:59
92edce9 to
355b32f
Compare
Erica Vellanoweth (ericavella)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*Countnaming across profiles and executors*IterationCount, including prefixed monitor, ping, and shader parametersValidation
dotnet build src\VirtualClient\VirtualClient.Actions.FunctionalTests\VirtualClient.Actions.FunctionalTests.csproj -c Debug --no-restore$.Parameters.*reference resolves