Repository navigation
fix(v2): map OpenAPI 2.0 response schema type file to binary format - #3150
Merged
Vincent Biret (baywet) merged 5 commits intoOct 27, 2026
Conversation
…schema deserializer
Contributor
Author
|
This PR addresses #3149 by bringing schema deserialization in OpenAPI 2.0 into alignment with parameter deserialization:
|
Contributor
Author
|
I've pushed an update addressing the failing response schema test in CI. In OpenAPI 2.0, response Ready for your review when you have a moment. |
Vincent Biret (baywet)
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
Resolves #3149.
In OpenAPI 2.0, the Response Object specifies:
While
OpenApiParameterDeserializeralready mapstype: filetoType = JsonSchemaType.StringandFormat = "binary",OpenApiSchemaDeserializerpreviously omitted settingFormat = "binary"whentype: filewas encountered. As a result, OpenAPI 2.0 response schemas returning files were deserialized into plain strings without format metadata.This PR adds:
Format = "binary"assignment whentypeequals"file"(case-insensitive) inOpenApiSchemaDeserializer, matchingOpenApiParameterDeserializer.OpenApiSchemaTests.csverifying both direct schema parsing and response object schema resolution fortype: file.Verification
type: file->JsonSchemaType.StringwithFormat = "binary"."binary".