Skip to content

TLSExplicit bool field: Added TLSExplicit bool field to Server struct with omitempty - #605

Closed
aniket866 wants to merge 1 commit into
microcks:masterfrom
aniket866:fix/TLSExplicit-bool-fields
Closed

aniket866 wants to merge 1 commit into
microcks:masterfrom
aniket866:fix/TLSExplicit-bool-fields

Conversation

@aniket866

Copy link
Copy Markdown
Contributor

Added TLSExplicit bool field to Server struct with omitempty so it's absent in old YAML files. When absent (false), the persisted insecureTLS value is untrusted (because the old login always wrote true unconditionally).

NewClient now:

  • Reads context's TLSExplicit : only honours InsecureTLS from the saved context when TLSExplicit == true; warns and ignores it for legacy configs
  • Computes effectiveInsecure : config.InsecureTLS (CLI flag) OR c.InsecureTLS (context), so later commands using a saved --insecure-tls context work without repeating the flag

Closes #286

Ai disclosure: chatgpt is used to reveiw related files and do required changes.

Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@Caesarsage

Copy link
Copy Markdown
Collaborator

Thanks @aniket866! mynk8 still has #287 open for this, so please coordinate with them there. If there's no reply by Nov 6, feel free to reopen this; otherwise pick another triage/accepted issue.

This branch was successfully deployed

1 active deployment
Build — 9101eef9 Deployed Oct 30, 2026 by aniket866 via build-verify-package #844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persisted context TLS settings are inconsistent for different HTTPS servers

2 participants