Repository navigation
Conversation
Contributor
|
would like to discuss this in person |
Gerrit91
force-pushed
the
members-improvements
branch
from
October 20, 2026 09:33
fced08b to
4ac3661
Compare
majst01
reviewed
Oct 20, 2026
Comment on lines
+49
to
+62
| message ProjectServiceCreateRequest { | ||
| // Login is the tenant of this project. | ||
| string login = 1 [(buf.validate.field).string.(metalstack.api.v2.is_name) = true]; | ||
| // Name of this project, unique per tenant. | ||
| string name = 2 [(buf.validate.field).string.(metalstack.api.v2.is_name) = true]; | ||
| // Description of this project. | ||
| string description = 3 [(buf.validate.field).string.(metalstack.api.v2.is_description) = true]; | ||
| // Avatar URL of the project. | ||
| optional string avatar_url = 4 [(buf.validate.field).string.(metalstack.api.v2.is_uri) = true]; | ||
| // Labels on the project. | ||
| metalstack.api.v2.Labels labels = 5; | ||
| // Project is the uuid of the project. | ||
| optional string project = 6 [(buf.validate.field).string.uuid = true]; | ||
| } |
Contributor
There was a problem hiding this comment.
this should already exist in api/v2/project.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on the CLI apply commands, I realized the following shortcomings in the API:
ProjectServiceRemoveMemberResponsereturnsProjectRoleinstead ofProjectMember, which is wrongIn order to fix these shortcomings, I turned the member methods into own CRUDs into dedicated services. The admin member add / remove methods need to stay because this allows unscoped member creation, for the regular API these calls must be scoped.
Used AI-Tools ✨