Repository navigation
rs_port: simplify is_initialized to fix clippy needless_bool - #962
Merged
viferga merged 1 commit intoNov 13, 2026
Merged
Conversation
Rust 1.100 clippy flags the if/return true/false in is_initialized with clippy::needless_bool, and the Rust Port Tests job fails because the workflow runs cargo clippy with -D warnings. Return the comparison directly. The behaviour is the same. Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
bhuvan-somisetty
force-pushed
the
fix/rs-port-needless-bool
branch
from
November 13, 2026 23:16
4bd5079 to
9d17e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.100 clippy reports
clippy::needless_boolonis_initialized()inrs_port/src/init.rs, and the Rust Port Tests job runscargo clippy -- -D warnings, so it fails. The job passed on 11-11 and failed on 11-12. This returns the comparison directly, same behaviour.Approved by viferga,No issue for this.
I did not run
cargo clippylocally (it needs the native metacall library built).rustfmt --checkpasses, so I am relying on the Rust Port Tests job.AI-ASSISTED: yes, Claude Sonnet 5.5 helped. Human reviewer: me (bhuvan-somisetty).