Skip to content

rs_port: simplify is_initialized to fix clippy needless_bool - #962

Merged
viferga merged 1 commit into
metacall:developfrom
bhuvan-somisetty:fix/rs-port-needless-bool
Nov 13, 2026
Merged

viferga merged 1 commit into
metacall:developfrom
bhuvan-somisetty:fix/rs-port-needless-bool

Conversation

@bhuvan-somisetty

@bhuvan-somisetty bhuvan-somisetty commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Rust 1.100 clippy reports clippy::needless_bool on is_initialized() in rs_port/src/init.rs, and the Rust Port Tests job runs cargo clippy -- -D warnings, so it fails. The job passed on 11-11 and failed on 11-12. This returns the comparison directly, same behaviour.

Approved by viferga,No issue for this.

I did not run cargo clippy locally (it needs the native metacall library built). rustfmt --check passes, so I am relying on the Rust Port Tests job.

AI-ASSISTED: yes, Claude Sonnet 5.5 helped. Human reviewer: me (bhuvan-somisetty).

Rust 1.100 clippy flags the if/return true/false in is_initialized with
clippy::needless_bool, and the Rust Port Tests job fails because the
workflow runs cargo clippy with -D warnings.

Return the comparison directly. The behaviour is the same.

Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
@bhuvan-somisetty
bhuvan-somisetty force-pushed the fix/rs-port-needless-bool branch from 4bd5079 to 9d17e94 Compare November 13, 2026 23:16
@viferga
viferga merged commit 8430ccb into metacall:develop Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants