Repository navigation
Answer a request no metadata leader admitted as 503 and refuse a heartbeat TTL under three intervals - #684
Merged
Conversation
… heartbeat TTL under three intervals A PreconditionFailed saying the request was not admitted by a leader (an election, or the first seconds of a cluster) took the lost-race path as well: retried at once, then 412. It is now a retryable 503 like the placement refusal. The bring-up script takes the chunk heartbeat interval as a variable and stops when the heartbeat TTL is under three intervals. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #682.
What
PreconditionFailedsaying the request "was not admitted by a leader" (an election, or the first seconds of a cluster, which the QPS rig saw right after a cluster came up) took the same lost-race path as the placement refusal fixed in Answer a placement with no healthy group as 503 and keep the heartbeat TTL above one interval #682: the gateway retried it at once and then answered 412 "the object kept changing under this append". It is now a retryable 503 with the reason (leader_unavailable).scripts/cluster_gateway_bringup.shtakes the chunk heartbeat interval asCHUNK_HEARTBEAT_MS(default 200 in this script, 3000 in the product) and stops with an error whenHEARTBEAT_TTL_MSis under three intervals. Checked: TTL 5000 with an interval of 3000 stops with "HEARTBEAT_TTL_MS=5000 is under three chunk heartbeat intervals (3000 ms)"; the defaults start.Tests
a_request_no_leader_admitted_is_a_503_and_not_a_lost_race(a plane refusing one append that way: 503, the reason in the body, nothing written, the retry lands).cargo check --all-targetswith-D warnings.Not changed
The chunk server's heartbeat itself (it skips a whole interval when the replica lock is busy) is a separate finding, not touched here.
🤖 Generated with Claude Code