Repository navigation
MLE-33564 Fix the 5 fixable disabled tests - #1985
hmadala001 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the changes re-enabling bulk and temporal test coverage.
No open issues 🎉
What changed in this PR
Re-enables five disabled tests in the core client and functional test suites by removing bulk-test ordering dependencies and making temporal query periods independent of the JVM’s default timezone.
Changes:
- Loads city data once in
@BeforeAlland changes the bulk-load test to verify the loaded count. - Derives temporal query boundaries from shared valid-time constants using UTC and one-second offsets.
- Removes
@Disabledfrom three bulk tests and two temporal tests.
| File | Description |
|---|---|
marklogic-client-api/src/test/java/com/marklogic/client/test/BulkReadWriteTest.java |
Initializes shared city data before all tests and re-enables bulk load, read, and search coverage. |
marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/TestBiTemporal.java |
Adds UTC query-period construction and re-enables two ALN_CONTAINS tests. |
Review effort: Balanced
BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch): - Load cities_above_300K.txt in @BeforeAll so the tests no longer depend on running in method-name order; testA_BulkLoad now verifies the loaded count. - Removed @disabled. TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains): - Query periods are now derived by offsets from the valid times the test writes, and are built in UTC rather than the JVM default timezone, which made the tests fail whenever the JVM was not running in UTC. - Removed @disabled. MLE-33564 Update copyright year to 2026 in BulkReadWriteTest The Validate Copyright Headers check requires modified files to carry the current year. Revert "MLE-33564 Temporarily pin PR build to MarkLogic 12.2.20261005" This reverts commit 493a518. Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
2149752 to
32361f1
Compare
prgs-rsingh
left a comment
prgs-rsingh
left a comment
There was a problem hiding this comment.
Great root-cause fix on both fronts:
BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch): Moving cleanUp() and loadCities(new BulkCityWriter()) into @BeforeAll removes the method-ordering dependency while keeping loadCities available for JacksonDatabindTest and PojoFacadeTest.
TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains): Constructing the Calendar bounds in UTC via utcValidTime(validTime, offsetSeconds) resolves the timezone mismatch between a non-UTC client JVM and the UTC MarkLogic Docker container when StructuredQueryBuilder.period(Calendar, Calendar) serializes the Calendar with its timezone offset.
BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch):
TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains):
https://ml-clt-jenkins.progress.com/blue/organizations/jenkins/devexp%2FJava-Client%2Fjava-client-api/detail/PR-1985/3/tests