Repository navigation
feat: expose user picture and token attributes - #67
Merged
Merged
Conversation
- UserRepresentationDTO gets an optional `picture`, read from the standard `picture` claim with a fallback to the `picture` user attribute. - KeycloakResourceOwner gets getAttributes() and getAttribute(), reading the `attributes` claim (e.g. a custom `agency_id` mapper). Both additions are backward compatible: `picture` defaults to null and is the last constructor argument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two additive read accessors for data Keycloak already puts in the token.
pictureis the last constructor argument and defaults tonull, so existingnew UserRepresentationDTO(...)calls keep working.Evidence
main):tests/DTO/UserRepresentationDTOTest.phpandtests/Token/KeycloakResourceOwnerTest.phpfail.$dto->pictureis an undefined property, andgetAttributes()/getAttribute()are undefined methods.vendor/bin/phpunit→OK (121 tests, 851 assertions)on PHP 8.4. The new tests cover: picture from the standard claim, the fallback to the user attribute, null when missing, the attributes claim, and the missing claim and missing key.Merge Danger
Door: two-way
Additions only: nothing is removed or renamed. Reverting the PR removes the accessors.
Blast Radius: minimal
The only consumers that change are those that start calling the new accessors. Subclasses of
KeycloakResourceOwnerthat already definegetAttributes()/getAttribute()with a different signature would conflict.🤖 Generated with Claude Code