Repository navigation
feat(cli): set jsonSchema.maxLength when discovering string models - #11896
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
`lb4 discover` copied the column length into the `length` property only. That property is metadata for the connectors and is not evaluated by request validation, so over-long values were silently truncated by databases in non-strict mode and surfaced as internal server errors in strict mode. Mirror the discovered length of `string` properties into `jsonSchema.maxLength` (keeping `length` untouched) so that LoopBack rejects such input with a validation error. An existing `jsonSchema` (for example the enum values) is preserved. Non-string properties are not affected. Fixes loopbackio#11869 Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11869
lb4 discoveronly emitted the column length as thelengthproperty, which is not evaluated by request validation. Over-long values were therefore truncated silently (non-strict SQL mode) or caused an internal server error (strict mode).Discovered
stringproperties with a positive integerlengthnow also getjsonSchema: {maxLength: <length>};lengthis kept. An existingjsonSchemais preserved and non-string properties are untouched.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated