Repository navigation
fix: harden and unit test src/lib/utils/exec.ts - #46
Merged
Merged
Conversation
- exec runs only allowlisted commands (npm, pnpm, yarn, bun, gh, git) and refuses anything else before spawning. - A spawn failure, such as a missing binary, now rejects with "Failed to execute command" and the original error as its cause. A timeout is recognised by the code's own state, not by the error text. - Remove the unused execOrThrow. - Add sandboxed tests for the allowlist, spawn errors, non-zero exits, timeout and kill, timer cleanup, output capture, cwd and env. exec.ts is now at 100% coverage. - Raise the coverage floors to 91% functions and 82% lines. Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
execnow runs only the commands its callers use (npm,pnpm,yarn,bun,gh,git). Anything else is refused before a process starts.Failed to execute commandand keeps the original error ascause. A timeout is recognised by the code's own state, not by matching the error text.execOrThrow.tests/lib/utils/exec.test.ts(28 tests, run only in the Docker sandbox). It covers the allowlist, spawn errors, non-zero exits, timeout and kill (checked by PID), timer cleanup, output capture, the absence of shell interpretation, andcwd/env.exec.tsgoes from 0% to 100% coverage.