Repository navigation
ci: stop automatic major releases - #40
Merged
Merged
Conversation
Move version selection into scripts/next-version.sh. Breaking markers now bump minor with a warning, and the major never changes. scripts/assert-same-major.sh guards the bump push and the tag push, fails closed on missing or malformed tags, and the version step runs with pipefail and reads full history when no tag exists. Closes #37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
The release workflow turned any
!marker orBREAKING CHANGEinto a major bump, so one stray marker would have published v1.0.0.Changes
scripts/next-version.shnow picks the next version. Breaking markers (type!:,BREAKING CHANGE:/BREAKING-CHANGE:footers) bump minor with a::warning::;featbumps minor; everything else bumps patch. The major never changes. Commit bodies are now read, not only subjects.scripts/assert-same-major.shrefuses any major change and fails closed on missing or malformed tags. It runs before the version files are updated and pushed, and again before the tag is pushed.pipefail, so agit logfailure stops the release instead of shipping a patch. With no tag, it reads the full history.docs/RELEASING.mdis updated: a major is now a manual decision (just bump-major).Tests
tests/scripts/next-version.test.tsandtests/scripts/assert-same-major.test.ts. Every test was confirmed to fail when the logic it guards is broken../scripts/check-coverage.sh(459 pass), build, shellcheck and actionlint all pass.After merge
refs/tags/v[1-9]*.