Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description / Motivation
When a late tick jumps over an interval 4 where we propose the next slot, that block is never built and
lean_block_building_failures_totalstays at 0. This makes the case visible.What Changed
crates/blockchain/src/lib.rs:skipped_build_slotsfinds the interval-4 ticks a late tick jumped over;on_ticklogs a warn and bumps the counter for each one where we are the proposer.crates/blockchain/src/metrics.rs:lean_block_proposals_missed_total.docs/metrics.md: one row for the new metric.Correctness / Behavior Guarantees
Log and metric only. The root cause at the rotation wrap is left alone.
Tests Added / Run
Three unit tests for
skipped_build_slots. They cover the helper, not its call insideon_tick.Related Issues / PRs
✅ Verification Checklist
make fmt— cleanmake lint(clippy with-D warnings) — cleanmake test(cargo test --workspace --profile release-fast) — all passing