Repository navigation
feat: delete_key for DELETE /key - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
delete_key(params, idempotency_key=None)withDeleteKeyParams/DeleteKeyResponseTypedDicts, a README table row and an Unreleased CHANGELOG entry. No version bump.Contract
DELETE /key,Authorization: Bearer <admin key>, JSON body{"productId", "licenseKey"}. 200{"message": "Key deleted", "code": 0}; 404{"message": "Invalid license key", "code": 1}raisesKeyMintApiError(status 404, code 1).Request helper
_handle_requestgains an optionaldelete_bodyargument. The DELETE branch sendsjson=delete_bodyonly when it is given; otherwise it makes exactly the samerequests.delete(url, params=..., headers=...)call as before, sodelete_customeris unchanged. The license key never goes in the URL or query string.Tests
Contract tests in
tests/test_contracts.py: method, URL/key, JSON body with both fields, no query params, license key absent from the URL, auth and content-type headers, 200 parsing, 404 raises. Regression test:delete_customerstill sends onlyparams={"customerId": ...}and headers, no body.ruff check .,pytest -q tests(84 passed) andpython -m buildpass locally.