Repository navigation
feat: deleteKey for DELETE /key - #5
Merged
Merged
Conversation
Adds deleteKey({ productId, licenseKey }), sending the license key in the
JSON body. The DELETE helper takes an optional body; deleteCustomer is
unchanged. The live test now deletes the keys it creates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
deleteKey({ productId, licenseKey }), which permanently deletes a license key.blockKeystays the reversible option.Contract
DELETE /keywith JSON body{ productId, licenseKey }. The license key goes in the body, never the URL. 200 returns{ message: "Key deleted", code: 0 }. An unknown key returns 404{ message: "Invalid license key", code: 1 }, which the SDK rejects as{ message, code, status }. The DELETE helper now takes an optional body.deleteCustomerstill uses query params and is unchanged.Tests
getKeyfails for it. Thefinallyblock now deletes both created keys instead of blocking them, so the shared test workspace stops filling up.README and CHANGELOG (Unreleased) are updated. No version bump.