Repository navigation
feat: DeleteKey for DELETE /key - #5
Merged
Merged
Conversation
Adds Client.DeleteKey (DeleteKeyParams/DeleteKeyResponse, re-exported from /src). The license key goes in the JSON body, never the URL. The live test now deletes the keys it creates instead of only blocking them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Client.DeleteKey(DeleteKeyParams) (*DeleteKeyResponse, error), typed and implemented likeBlockKey, and re-exported from the deprecated/srcpackage.Contract
DELETE /keywithAuthorization: Bearer <admin key>and JSON body{ "productId", "licenseKey" }. The license key goes in the body, never the URL. 200 returns{ "message": "Key deleted", "code": 0 }. 404 returns{ "message": "Invalid license key", "code": 1 }as an*ApiError. Needs an admin key or thelicense:deletepermission.No HTTP helper change:
handleRequestalready sends a JSON body for any method.Tests
TestDeleteKey*(mock server) check the method, path, JSON body, that the key is not in the URL, the auth header, and that 200 and 404 both parse. Added to the CI-runfilter.DeleteKeythrough both import paths.gofmt -l .(clean),go vet ./...,go test ./...all pass. The live test skips without secrets.