Repository navigation
feat: expose expirationDate on activate and floating checkout - #3
Merged
Merged
Conversation
Add ExpirationDate (*string) to ActivateKeyResponse and FloatingCheckoutResponse. nil means the license never expires. Additive and backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ActivateKeyResponse.ExpirationDate *string(json:"expirationDate,omitempty")FloatingCheckoutResponse.ExpirationDate *string(json:"expirationDate,omitempty")Same type and tag as the existing
LicenseDetails.ExpirationDate. Bothnulland a missing field decode tonil. Nothing else changes, and no signatures change. The/srccompat package picks this up through its type aliases.API contract (live)
POST /key/activatesuccess now includesexpirationDate: an ISO 8601 string (e.g."2027-03-01T00:00:00.000Z") ornullwhen the license never expires.POST /key/checkoutsuccess includes the sameexpirationDate(license expiry). It is separate fromexpiresAt, which is the floating seat lease.expirationDatethey received.Tests
TestActivateKeyDeserializesExpirationDateandTestFloatingCheckoutDeserializesExpirationDate(date /null/ absent). Their names match the CI contract-test filter.gofmt -l .: clean.go vet ./...: clean.go build ./...: ok.go test ./... -v: all pass. The live suite is skipped locally because no credentials are set.No version bump. Releases are tag-only, with no version constant in the code.