Repository navigation
Support per-build registry credentials - #572
sjmiller609 wants to merge 4 commits into
Conversation
-->
✱ stlc build✅ go code · compare
✅ python code · compare
✅ typescript code · compare
Diagnostics: ❗ 0 new / 1 total error, 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
|
Additional end-to-end validation at af90b44: ran an isolated Hypeman API with the rebuilt builder image on a KVM-capable Linux host, using a private TLS registry and synthetic per-request credentials.
This validates the full API → vsock → guest Docker config → BuildKit private-FROM path, not AWS-specific token issuance or the platform caller integration. No production ECR credentials used and no code changes were needed. |
…ry-auth # Conflicts: # lib/oapi/oapi.go
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f9e7b1f. Configure here.
|
Picked hiroTamada to review: strongest familiarity with the changed build code; 3 pending reviews. |

Summary
Validation
Experimental validation
Tested af90b44 with isolated Hypeman, the rebuilt builder image, real KVM guests, and a private TLS registry:
Detailed results
Rollout / scope
Rebuild and deploy the builder image before enabling credentialed callers. No refresh protocol: callers resubmit interrupted/expired builds with fresh credentials. Underlying registry/IAM permissions still determine token scope; callers should use pull-only access to required repositories.
This PR is Hypeman only. Platform issuance, API FROM references, CLI flags, and SDK caller updates are separate follow-ups. No deployment or image publication performed.
Note
High Risk
Touches credential handling, vsock delivery, and build lifecycle/recovery paths; mistakes could leak secrets or allow builds with stale or overly broad upstream access.
Overview
Adds optional
registry_credentialsonPOST /builds: a bounded JSON map of upstream registry username/password pairs (with optional expiry) so builds can pull privateFROMimages without host-wide registry secrets.The API and build manager validate input (host shape, size limits, no local-registry override), keep credentials only in memory for up to 30 minutes, and do not persist them to build metadata or config disks. Credentialed builds skip shared base-image mirroring; the manager hands credentials to the builder over a new vsock handshake and rejects old builder images that never request them.
The builder agent waits for borrowed credentials, merges them into ephemeral 0600 Docker auth config beside the local push token, omits the Docker Hub mirror when credentialed, redacts secrets in logs/errors, and deletes auth files after the build. Interrupted credentialed builds fail closed on recovery (no replay without resubmit). OpenAPI/docs and builder image packaging include the new
registryauthmodule.Reviewed by Cursor Bugbot for commit 93d1461. Bugbot is set up for automated code reviews on this repo. Configure here.