Skip to content

ci: lock workflow dependencies with GitHub's actions.lock - #6

Closed
rgarcia wants to merge 1 commit into
mainfrom
hypeship/actions-lockfile
Closed

rgarcia wants to merge 1 commit into
mainfrom
hypeship/actions-lockfile

Conversation

@rgarcia

@rgarcia rgarcia commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Adds GitHub's workflow dependency lockfile. .github/workflows/actions.lock records the commit behind every action the workflows use (including actions those actions use), so the code that runs can't change underneath them.

  • Added .github/workflows/actions.lock, generated with gh actions-lock --no-narrow. The lockfile keys are the generator's existing SHA pins, each recorded with its release tag (e.g. actions/checkout@de0fac2… → v6.0.2), so regenerated workflows keep matching it. gh actions-lock --verify passes (all 6 workflows valid).
  • One workflow line changes: release-please.yml pinned pnpm/action-setup@f40ffcd…, which is the SHA of the annotated v4 tag object rather than a commit. A lockfile entry keyed by a SHA must record that same commit, so that ref can't be locked. It now pins b906aff… (v4.3.0), the commit the tag peels to, so the code that runs is unchanged. The generator template needs the same change so later promotions match.
  • Every other uses: line is unchanged.
  • pypa/gh-action-pypi-publish uses actions/setup-python internally; that is locked transitively. It also runs a Docker action it writes into the workspace at run time, which the lockfile can't follow (warning only).
  • Refresh this lockfile with gh actions-lock --no-narrow; a default run rewrites the SHA pins to tags and diverges from the generator output.

No reusable workflow calls in this repo.

@rgarcia
rgarcia force-pushed the hypeship/actions-lockfile branch from 5a10de9 to a660d97 Compare November 13, 2026 21:28
@rgarcia
rgarcia force-pushed the hypeship/actions-lockfile branch from a660d97 to d49ecb8 Compare November 13, 2026 21:30

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d49ecb8. Configure here.


- name: Set up pnpm
uses: pnpm/action-setup@f40ffcd9367d9f12939873eb1018b921a783ffaa # v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewritten action pin will not persist

Medium Severity

The lockfile onboards release-please.yml after rewriting pnpm/action-setup from the annotated v4 tag object to commit b906aff. The generator still emits that tag-object SHA, so the next regeneration restores a uses ref the lockfile does not cover and verification fails.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d49ecb8. Configure here.

@rgarcia

rgarcia commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of kernel/hypeman-python-staging#1, which landed the same change (actions.lock + the pnpm/action-setup pin) on staging. It was promoted to next (d931b48) and will reach main with the release PR #5, which keeps the production -> staging back-sync fast-forward-only.

@rgarcia rgarcia closed this Nov 13, 2026
@rgarcia
rgarcia deleted the hypeship/actions-lockfile branch November 13, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant