Skip to content

fix: reconcile editor tabs after terminal rm - #127

Merged
kbuffardi merged 2 commits into
mainfrom
fix/terminal-rm-tab-reconciliation
Nov 3, 2026
Merged

kbuffardi merged 2 commits into
mainfrom
fix/terminal-rm-tab-reconciliation

Conversation

@kbuffardi

Copy link
Copy Markdown
Owner

Summary

  • reconcile open editor tabs after a successful terminal rm
  • close tabs for descendants of recursively removed directories
  • preserve existing runtime-delete tab behavior and leave failed deletion unchanged

Verification

  • npm run lint
  • npm run test:e2e
  • npm run build

Closes #126

Close tabs for files and recursively removed directories only after their host-backed terminal rm deletion succeeds.\n\nFixes #126
Wire the application removal handler into the terminal so rm reaches the host-backed workspace deletion API, and report an unavailable service instead of silently succeeding.
@kbuffardi

Copy link
Copy Markdown
Owner Author

Root-cause update after reproducing the reported behavior:

rm .DS_Store produced no error and left the file in both the Explorer and
host folder.

app.js supplied onRemove, but createTerminal() did not accept or assign it,
leaving the terminal's removal callback unset. Terminal rm therefore took an
optional-call no-op path. The PR now binds that callback, adds dotfile coverage,
and reports Filesystem unavailable rather than claiming success when the
service is absent.

@kbuffardi
kbuffardi merged commit 30bba68 into main Nov 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: reconcile editor tabs after terminal rm

1 participant