You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(toolbar): align settings control geometry #128
The Settings toolbar control uses a Unicode gear. Its font metrics produce a
taller inline box than the Monaco Codicon icons used by nearby toolbar controls,
making the Settings button visibly taller.
Proposed change
Use Monaco's shared codicon-gear glyph for Settings, preserving the existing
button label and accessible name. Add regression coverage that verifies matching
toolbar icon sizes and rendered dimensions.
Decision: replace the Unicode gear with Monaco's shared codicon-gear rather
than tuning Unicode font metrics. This makes both the glyph box and Settings
button height match neighboring Codicon-based controls while preserving the
visible Settings label and accessibility attributes.
Validation completed:
npm run lint
npm run build
npm run test:e2e (239 passing tests)
The Chrome smoke run passed the new Settings geometry checks, then stopped at
the unrelated existing failure vs terminal selection foreground is incorrect.
Activity
kbuffardi commentedon Nov 4, 2026
Implemented on
fix/settings-toolbar-geometry.Decision: replace the Unicode gear with Monaco's shared
codicon-gearratherthan tuning Unicode font metrics. This makes both the glyph box and Settings
button height match neighboring Codicon-based controls while preserving the
visible Settings label and accessibility attributes.
Validation completed:
npm run lintnpm run buildnpm run test:e2e(239 passing tests)The Chrome smoke run passed the new Settings geometry checks, then stopped at
the unrelated existing failure
vs terminal selection foreground is incorrect.Pull request: #129.
fix(toolbar): align settings control geometry (#129)