Repository navigation
ci: install a fixed Helm version in helm-e2e and helm-verify - #96
Open
QuentinBisson wants to merge 1 commit into
Open
QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
azure/setup-helm without a version input installs whatever get.helm.sh/helm-latest-version returns, and falls back to v3.18.4 when that lookup fails (src/run.ts at v4.3.1). A run could therefore lint, render and install the chart on a different Helm major than the previous one. Install v4.3.1 in both workflows. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
marked this pull request as ready for review
October 23, 2026 09:59
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Oct 23, 2026
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Oct 23, 2026
* docs(fork): T16 upstream state as of 2026-10-23 kagent-dev#71 carries the restarted-container dump as its second commit; the Helm version pin is kagent-dev#96; the helm-verify checkout bump stays fork-only. Signed-off-by: QuentinBisson <quentin@giantswarm.io> * docs(fork): kagent-dev#96 is ready for review Signed-off-by: QuentinBisson <quentin@giantswarm.io> --------- Signed-off-by: QuentinBisson <quentin@giantswarm.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
helm-e2e and helm-verify run
azure/setup-helmwithout aversioninput. The action then installs whateverhttps://get.helm.sh/helm-latest-versionreturns, and falls back to Helmv3.18.4when that lookup fails (src/run.tsat v4.3.1). A run can therefore lint, render and install the chart with a different Helm major version than the run before it.Change
Pass
version: v4.3.1toazure/setup-helmin both workflows.