Repository navigation
Support Android NDK 18+ (#1659) - #1744
Open
BugsBeGone wants to merge 1 commit into
Open
BugsBeGone wants to merge 1 commit into
BugsBeGone wants to merge 1 commit into
Conversation
Contributor
Author
|
Forgot to mention, I have no opinion whatsoever about whether the shipped binaries should actually be upgraded or not, I understand that testing anything like this is extremely tedious at the best of times. This is purely intended to help those wanting to build jnidispatch.so from source, who may at some point be unable to use or even obtain ancient NDK toolchains. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backwards compatible changes to native makefile, such that ancient GCC-based toolchains can still be used, but also allow newer LLVM-based tools from NDK 18 onwards.
When building with anything available from the Android SDK manager currently, all that should be necessary is to set
$NDKto the top-level path, and$NDK_PLATFORMto the target SDK level. If noPkg.Revisioncan be found, you will also need to set$NDK_VERto the major version.Checks for armv5 & MIPS target architectures are also performed, which are not supported from NDK 17,