Repository navigation
Target Java 11 bytecode - #2750
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the project's Java requirement from version 8 to version 11, updating both the README and the Gradle build configuration. Feedback indicates that the documentation update is inconsistent with the 'How to Build' section and notes that Android developers will require core library desugaring to support Java 11 APIs on older devices.
| - platform-neutral core library for scene graph, animation, rendering, math, etc. | ||
| - LWJGL v2/v3 (to access GLFW, OpenAL, OpenGL, and OpenVR) or Android or iOS | ||
| - Java Virtual Machine (v8 or higher) | ||
| - Java Virtual Machine (v11 or higher) |
There was a problem hiding this comment.
The update to Java 11 is a breaking change for users on older JVMs. This requirement is currently inconsistent with the build instructions in the 'How to Build' section (line 70), which should also be updated to specify JDK 11. Additionally, Android developers will need to enable core library desugaring to support Java 11 APIs on devices with API levels below 30.
|
The current ios backend is compatible only with java8, so for now we are stuck on that. |
|
New ios backend is merged, so we are not stuck on java 8 anymore. This can be rebased on the new master branch |
0c386b3 to
f298636
Compare
|
What is the status of this PR? I'd like to use Cleaner from java 9, but if we're still targeting java 8 I'll go with something else. |
| - platform-neutral core library for scene graph, animation, rendering, math, etc. | ||
| - LWJGL v2/v3 (to access GLFW, OpenAL, OpenGL, and OpenVR) or Android or iOS | ||
| - Java Virtual Machine (v8 or higher) | ||
| - Java Virtual Machine (v11 or higher) |
There was a problem hiding this comment.
This line now says Java 11, but the “How to Build” instructions below still tell developers to use a Java 17 installation, which is inconsistent with this updated requirement. Please update that guidance to say JDK 11 (or clarify the required build JDK separately).
jaime-jmebot
left a comment
jaime-jmebot
left a comment
There was a problem hiding this comment.
- The bytecode target is now Java 11, but the build instructions still specify JDK 17, so the documented requirements should be reconciled.
- Please also verify the Android backend’s compatibility with this target before merging.
1357f0a to
646ce61
Compare
|
Thanks! |
Target Java 11 instead of Java 8, now that the new iOS backend has landed.
Update the README to distinguish the Java 11 runtime requirement from the build requirements: JDK 17+ to run Gradle, with a JDK 25 compiler toolchain. Also add two missing
@Deprecatedannotations that caused compilation to fail with the new target.Core tests (1,140), the Android backend build, and Android examples/test APK builds pass. The build and Android screenshot CI workflows pass too.