Skip to content

Add temporary S3 bucket manual override to Sim 6.2 - #95

Merged
peterd-NV merged 1 commit into
mainfrom
peterd/staging_link_fix
Nov 4, 2026
Merged

peterd-NV merged 1 commit into
mainfrom
peterd/staging_link_fix

Conversation

@peterd-NV

@peterd-NV peterd-NV commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Sim 6.1 bucket that Arena v0.3.1 uses has been deleted and migrated to Sim 6.2. AutoData will remain on Sim 6.1 for v0.2 so add a temporary manual override to use 6.2 bucket.

Add a CI reminder test to flag when this can be removed.

Summary by CodeRabbit

  • Bug Fixes
    • Updated Arena and Isaac staging asset references from Isaac 6.1 to Isaac 6.2.
  • Tests
    • Added checks for staging asset configuration.

@peterd-NV
peterd-NV requested a review from njawale42 as a code owner November 4, 2026 16:05
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The environment module updates two Arena nucleus directory values to use /Isaac/6.2/. A CI test checks that the corresponding upstream asset URLs do not contain that version path.

Changes: Arena asset paths

Layer / File(s) Summary
Path overrides and validation
autodata_examples/envs/__init__.py, autodata_tests/utils/test_staging_assets.py
The environment module updates both directory values from /Isaac/6.1/ to /Isaac/6.2/. The test checks that neither upstream URL contains /Isaac/6.2/.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: Minimal · up to aaf29

This change temporarily points two Arena asset directories at the Sim 6.2 bucket and adds a CI reminder to remove the override. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the temporary S3 bucket override for Sim 6.2, which is the main change.
Description check Passed The description explains the reason for the change, the manual override, and the CI reminder test. It is mostly complete, but it does not use the required Detailed description heading and the Summary …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the reason for the change, the manual override, and the CI reminder test. It is mostly complete, but it does not use the required Detailed description heading and the Summary exceeds the 50-character limit.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0e5c449 and aaf2900.

Files selected for processing: 2
  • autodata_examples/envs/__init__.py
  • autodata_tests/utils/test_staging_assets.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@peterd-NV
peterd-NV merged commit 59cacf4 into main Nov 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants