Repository navigation
fix(WO79): ORT shim create() accepts session options (fixes main build) - #119
Merged
Merged
Conversation
The single-thread decode session option needs the shim's create signature to accept options; the omission broke the build on main (merged ahead of its CI -- fix-forward).
ronaldtse
force-pushed
the
fix/session-opts-types
branch
from
November 8, 2026 22:01
f4592fa to
78752a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-thread session option in the conformance-matrix work called InferenceSession.create with options, but the repo ORT shim declared a one-arg signature -- build broke on main. Extends the shim signature; main is red until this lands, so merging on green-build only.