Repository navigation
License: GNU GPL v2 instead of MIT - #9
Merged
Merged
Conversation
LICENSE, composer.json, the module definition, the README and the file headers now say GPL v2 instead of MIT, in line with iForum and ImpressCMS. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MZy45V5RV9nx6Buq8vqKHr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
David confirmed that imforum goes back to the GNU GPL v2, like iForum and ImpressCMS. This is a license-only change, on its own so it can be reviewed apart. Stacked on #8 so that every file, including the ones added in phases 5 to 7, is covered.
LICENSE: the GPL v2 text (the same text iForum ships)composer.json:GPL-2.0-onlysrc/icms_version.php:licensesays GNU GPL v2@licensein the file headers:GNU GPL v2, see LICENSENo code changes. Unit tests pass.
Note: I used
GPL-2.0-only, matching "GPL v2". If "or later" is meant, it is a one-line change incomposer.json.Generated by Claude Code