Skip to content

Migrate toolchain to current store requirements and remove wrong submission charge limits flag - #1293

Open
KirillovProj wants to merge 13 commits into
developfrom
feature/store-requirements-migration
Open

KirillovProj wants to merge 13 commits into
developfrom
feature/store-requirements-migration

Conversation

@KirillovProj

Copy link
Copy Markdown

YouTrack Issues:
none

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens; (no new screens)
  • View analytics events are added for new screens; (no new screens)
  • New analytics events are documented; (no new events)
  • All checks have been passed;
  • Changes have been checked locally; (not possible: no local build environment, verified on CI only)
  • Saved in the cache models serialization checked locally.

Description

Brings the project up to the current App Store and Google Play submission requirements, and removes one feature flag. Suggested merge method: squash (the branch contains two temporary diagnostic commits).

1. Remove freemium.wrong_submission_charge_limits feature flag

The app now always behaves as if the flag is enabled for everyone:

  • a problems limit ("life") is charged for a wrong submission;
  • a correct submission charges nothing; the "+10 limits for the first solved step" bonus is kept;
  • the limits modal always shows the "lives" texts; the strings of the removed "limits" variant are deleted.

FreemiumChargeLimitsStrategy and every chargeLimitsStrategy parameter are removed from shared code, tests, Android and iOS.

2. Toolchain migration

Before After Why
Kotlin 1.9.24 2.2.21 minimum for Xcode 26
AGP / Gradle 8.2.2 / 8.3 8.11.1 / 8.14.3 required for API 36
targetSdk / compileSdk 35 36 Google Play requirement since 2026-08-31
RevenueCat Android 8.6.0 9.29.1 Play Billing Library 8, Google Play requirement since 2026-08-31
Xcode / iOS runners 15.4 / macos-14 26 / macos-26 App Store requirement since 2026-04-28
Sentry iOS 8.17.2 8.58.4 older versions do not compile with Xcode 26
fastlane 2.226.0 2.232.2

Also updated for Kotlin 2: Compose compiler plugin, moko-resources 0.25.2, BuildKonfig 0.17.1, Sentry Gradle plugin 5.12.2, Dokka 2.0.0, detekt 1.23.8, google-services 4.4.4.

Notable details:

  • Swift fixes from the unfinished ALTAPPS-1359 (Xcode 16) branch are applied.
  • Pods are built with the app deployment target (iOS 14): RevenueCat 4.41.1 does not compile for lower targets with Xcode 26. The same is applied to the pods the Kotlin CocoaPods plugin builds for cinterop (shared/build.gradle.kts).
  • moko-kswift is archived upstream but still works with Kotlin 2 with two workarounds in shared/build.gradle.kts: cinterop klibs are excluded from processing (they terminate the Gradle daemon), and the project klib is passed to the processor explicitly (it is no longer among the link task inputs). A migration to SKIE will be needed eventually.
  • ProgrammingLanguageExtension.kt: the R class is imported with an alias, because K2 resolves R to the star-imported ProgrammingLanguage.R enum entry.
  • CI: ktlint SARIF upload no longer fails the job, SwiftLint job generates the dummy framework before pod install on a cache miss, iOS build timeout is 60 minutes.
  • Podfile.lock is the one resolved by CocoaPods on CI; spec checksums of AppAuth, GoogleSignIn and GTMAppAuth changed upstream, versions are unchanged.

Verification

All CI checks pass: ktlint, detekt, SwiftLint, shared unit tests, Android unit tests, iOS debug build with Xcode 26.6.

Not verified:

  • the app has not been run on a device or simulator on either platform (purchases with RevenueCat 9 and Android 16 behaviour are the most sensitive areas);
  • Android release build (R8 minification) — it is built only by the deployment workflows;
  • iOS archive, code signing and upload — the last iOS beta deployments (December 2025) failed for an unknown reason.

These are exercised by the beta deployment that starts automatically after this PR is merged into develop (automerge into release/1.81).

🤖 Generated with Claude Code

KirillovProj and others added 13 commits November 18, 2026 16:27
Problems limits are now always charged for wrong submissions, as if the
flag was enabled for everyone. FreemiumChargeLimitsStrategy and the
strings of the removed "charge after correct submission" variant are deleted.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- Kotlin 2.2.21, AGP 8.11.1, Gradle 8.14.3
- targetSdk/compileSdk 36
- RevenueCat Android 9.29.1 (Play Billing Library 8)
- Xcode 26 on macos-26 runners
- fastlane 2.232.2
- Apply Xcode 16 source fixes from ALTAPPS-1359

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- Alias the R class in ProgrammingLanguageExtension: K2 resolves R to the
  star-imported ProgrammingLanguage.R enum entry
- Build pods with the app deployment target (iOS 14)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Podfile.lock is regenerated on CI and committed in a follow-up.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…e.lock for Sentry 8.58.4

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Also raise the iOS build job timeout and silence the Xcode compatibility warning.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Removes temporary diagnostics.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Spec checksums of AppAuth, GoogleSignIn and GTMAppAuth changed upstream;
versions are unchanged. Removes the temporary export step.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🎉 Welcome to Hyperskill Mobile App!

Thank you for your first contribution! We really appreciate your effort to improve the mobile learning experience for thousands of developers worldwide.

What happens next?

  • Our team will review your pull request thoroughly
  • We'll run automated checks and tests
  • We may provide feedback or request changes
  • Once approved, we'll merge your contribution

Before merge checklist

Please make sure you've completed the items in our PR template:

  • ✅ YouTrack issue linked
  • ✅ All checks passed
  • ✅ Changes tested locally
  • ✅ Analytics events documented (if applicable)

Resources

Thanks for contributing to coding education! 🚀

@github-actions github-actions Bot added documentation Improvements or additions to documentation shared Shared module task ios iOS module task android Android module task ci/cd dependencies Pull requests that update a dependency file config build-system ui feature learning testing payments gamification problems labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android Android module task build-system ci/cd config dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature gamification ios iOS module task learning payments problems profile root shared Shared module task testing ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant