Repository navigation
Migrate toolchain to current store requirements and remove wrong submission charge limits flag - #1293
Open
KirillovProj wants to merge 13 commits into
Open
KirillovProj wants to merge 13 commits into
KirillovProj wants to merge 13 commits into
Conversation
Problems limits are now always charged for wrong submissions, as if the flag was enabled for everyone. FreemiumChargeLimitsStrategy and the strings of the removed "charge after correct submission" variant are deleted. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- Kotlin 2.2.21, AGP 8.11.1, Gradle 8.14.3 - targetSdk/compileSdk 36 - RevenueCat Android 9.29.1 (Play Billing Library 8) - Xcode 26 on macos-26 runners - fastlane 2.232.2 - Apply Xcode 16 source fixes from ALTAPPS-1359 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- Alias the R class in ProgrammingLanguageExtension: K2 resolves R to the star-imported ProgrammingLanguage.R enum entry - Build pods with the app deployment target (iOS 14) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Podfile.lock is regenerated on CI and committed in a follow-up. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…e.lock for Sentry 8.58.4 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Also raise the iOS build job timeout and silence the Xcode compatibility warning. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Removes temporary diagnostics. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Spec checksums of AppAuth, GoogleSignIn and GTMAppAuth changed upstream; versions are unchanged. Removes the temporary export step. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🎉 Welcome to Hyperskill Mobile App!Thank you for your first contribution! We really appreciate your effort to improve the mobile learning experience for thousands of developers worldwide. What happens next?
Before merge checklistPlease make sure you've completed the items in our PR template:
Resources
Thanks for contributing to coding education! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
none
Checklist
Before Code Review:
Description
Brings the project up to the current App Store and Google Play submission requirements, and removes one feature flag. Suggested merge method: squash (the branch contains two temporary diagnostic commits).
1. Remove
freemium.wrong_submission_charge_limitsfeature flagThe app now always behaves as if the flag is enabled for everyone:
FreemiumChargeLimitsStrategyand everychargeLimitsStrategyparameter are removed from shared code, tests, Android and iOS.2. Toolchain migration
Also updated for Kotlin 2: Compose compiler plugin, moko-resources 0.25.2, BuildKonfig 0.17.1, Sentry Gradle plugin 5.12.2, Dokka 2.0.0, detekt 1.23.8, google-services 4.4.4.
Notable details:
ALTAPPS-1359(Xcode 16) branch are applied.shared/build.gradle.kts).moko-kswiftis archived upstream but still works with Kotlin 2 with two workarounds inshared/build.gradle.kts: cinterop klibs are excluded from processing (they terminate the Gradle daemon), and the project klib is passed to the processor explicitly (it is no longer among the link task inputs). A migration to SKIE will be needed eventually.ProgrammingLanguageExtension.kt: theRclass is imported with an alias, because K2 resolvesRto the star-importedProgrammingLanguage.Renum entry.pod installon a cache miss, iOS build timeout is 60 minutes.Podfile.lockis the one resolved by CocoaPods on CI; spec checksums of AppAuth, GoogleSignIn and GTMAppAuth changed upstream, versions are unchanged.Verification
All CI checks pass: ktlint, detekt, SwiftLint, shared unit tests, Android unit tests, iOS debug build with Xcode 26.6.
Not verified:
These are exercised by the beta deployment that starts automatically after this PR is merged into
develop(automerge intorelease/1.81).🤖 Generated with Claude Code