Repository navigation
Remove the Java test finder registration from the AI debugger Kotlin module - #65
Merged
Merged
Conversation
…module JTestFinder lives in the ai-debugger-java content module, which ai-debugger-kotlin does not depend on, so its classloader cannot load the class. ai-debugger-java already registers the same test finder for JAVA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ai-debugger-kotlin.xmlregisteredorg.hyperskill.academy.ai.debugger.java.impl.JTestFinderas thetestFinderforJAVA. That class lives in theai-debugger-javacontent module. It's an optional module with its own classloader, andai-debugger-kotlindoesn't depend on it, so the Kotlin module's classloader can't load the class. The platform would fail to create that extension when the AI debugger looks up a test finder for a Java test file (TestFinder.findTestByName).ai-debugger-java.xmlalready registers the same finder forJAVA, so this removes the duplicate line from the Kotlin module. Java test lookup is unchanged.Found while investigating EDU-9198 (#64). This error hasn't been reported, and I didn't reproduce it at runtime.
Testing