Repository navigation
fix(d2): quote identifiers to support special characters - #33
Merged
Merged
Conversation
D2 treats "." as a nesting separator, so table names containing dots produced invalid diagrams. ClickHouse tables created by materialized views (e.g. "db..inner_id.<uuid>") failed to compile with "unexpected text after map key". Quote every D2 key segment in the schema template. Table names are split at the first dot only, so the schema/database still becomes a container and the remainder is kept as a single table key. Column definitions and reference labels are quoted and escaped as well, which also fixes values containing double quotes. Closes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D2 treats "." as a nesting separator, so table names containing dots produced invalid diagrams. ClickHouse tables created by materialized views (e.g. "db..inner_id.") failed to compile with "unexpected text after map key".
Quote every D2 key segment in the schema template. Table names are split at the first dot only, so the schema/database still becomes a container and the remainder is kept as a single table key. Column definitions and reference labels are quoted and escaped as well, which also fixes values containing double quotes.
Closes #31