Repository navigation
chore(deps): refresh the lockfile to clear pnpm audit findings - #39
Draft
hideokamoto wants to merge 2 commits into
Draft
hideokamoto wants to merge 2 commits into
hideokamoto wants to merge 2 commits into
Conversation
…icitly picomatch 2.3.2, the release that fixes its extglob advisories, no longer matches the plugin's default include pattern `**/*.ts+(|x)`, so the plugin skips libs/*.ts and rollup fails with `Could not resolve "./configUpdator"`. Naming `*.ts` and `**/*.ts` keeps the same files in scope and builds the same dist/index.js with both picomatch 2.3.1 and 2.3.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BmzxkrdmVRTfR9rM1mwQ3B
`pnpm audit` on main reported 77 advisories (4 critical, 43 high), 21 of them in runtime dependencies, including fast-xml-parser 5.2.5 under @aws-sdk/client-cloudfront. Re-resolving every dependency to the newest version its package.json range allows leaves 2: minimatch 9.0.9 under @typescript-eslint 7 (fix needs minimatch 11) and deepmerge 4.3.1 under jest (no fixed release). No runtime advisories remain. package.json is unchanged, so the ranges published to npm stay the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BmzxkrdmVRTfR9rM1mwQ3B
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
main の
pnpm auditで 77 件(critical 4 / high 43)の advisory が出ていた。そのうち 21 件は実行時依存で、@aws-sdk/client-cloudfront配下の fast-xml-parser 5.2.5 の critical を含む。この PR で全依存を package.json の範囲内の最新版に解決し直し、advisory を 2 件まで減らした。実行時依存の advisory は 0 件になった。古い依存更新 PR 19 本(#2, #7〜#14, #16, #19, #24, #26, #28, #29, #31〜#34)は yarn.lock 前提で、#37 の pnpm 移行後はマージできないためクローズした。この PR はその代わりになる。
変更
rollup.config.js: rollup-plugin-typescript2 の対象ファイルをinclude: ['*.ts', '**/*.ts']と明示した**/*.ts+(|x)にlibs/index.tsが一致しなくなる(2.3.1 では一致する。node で直接確かめた)Could not resolve "./configUpdator"で失敗する。この変更でそれを防ぐpnpm-lock.yaml: 全依存を範囲内の最新版に解決し直した確かめたこと
pnpm audit: 77 件 → 2 件。pnpm audit --prodは 0 件pnpm install --frozen-lockfile→lint→typecheck→test --ci(12 件)→build)dist/index.jsと、この PR でビルドしたものは同一(sourcemap の行を除いて diff なし)注意
@aws-sdk/client-cloudfront3.1169.0 と関連パッケージは、engines にnode >=20.0.0を宣言しているengines.node: >=18.0.0で、実行時依存を^3.0.0で受けている。そのため利用者側でも、新しくインストールすれば同じ SDK が入る。これはこの PR とは関係なく、すでに起きている状態build:とchore(deps):だけなので、semantic-release のリリースは走らない想定(.releaserc.jsonは conventionalcommits のプリセット)Generated by Claude Code