Repository navigation
magento-integration: run the uninstall script by registering the module version - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/magento module:uninstall Hellotext_Tracking --remove-dataleft the Hellotext integration, its OAuth consumer and an active access token, plus thehellotext/*configuration, althoughSetup/Uninstall.phpdeletes all of them and the README says the command removes them.Magento only runs a module's
Setup\Uninstallfor modules listed insetup_module(Magento\Setup\Model\UninstallCollector). A module that uses declarative schema withoutsetup_versionis never added to that table, so the uninstall script was silently skipped.etc/module.xmldeclaressetup_version="1.0.2", sosetup:upgraderegisters the module.composer.jsonand the changelog.Verification
On the Magento 2.4.7-p10 test store, installing this branch with Composer:
setup_modulerow; after uninstall,integrationstill had "Hellotext", 1 OAuth consumer, 1 token and 3hellotext/*config rows.setup:upgradeaddsHellotext_Tracking 1.0.2tosetup_module;module:uninstall --remove-dataprints "Removing data of Hellotext_Tracking" and leaves 0 integrations, 0 consumers, 0 tokens and 0 config rows.After merge
Tag
1.0.2and update the package on Packagist (it is not auto-updated yet).