Repository navigation
magento-integration: release 1.0.1 with optional inventory and widget fonts - #3
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db8d5177a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes found while installing 1.0.0 from Packagist on a clean Magento Open Source 2.4.7-p10 store connected to a production Hellotext business.
magento/module-inventory-sales-api, so stores that removed or disabled MSI (a common performance setup) cannot install the module.StockManagementnow resolves the MSI services only whenMagento_InventorySalesApiis enabled and its classes exist (a removed MSI can leave a stale enabled flag), and otherwise reads Magento's default stock throughCatalogInventory. The MSI path is unchanged. MSI moves fromrequiretosuggest, andMagento_CatalogInventoryreplaces it in the module sequence.https://www.hellotext.com, whichfont-srcdid not allow. Magento reports the violation on storefront pages and blocks the fonts on pages where CSP is enforced, such as checkout.composer.jsonand the changelog (1.0.0 was still under "Unreleased"). The README notes that MSI is optional.Verification
On the test store (Magento 2.4.7-p10, PHP 8.3, MSI enabled), with this branch installed:
vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist <module>/Test/Unit: 65 tests passed, including a new case for the store without MSI.setup:upgradeandsetup:di:compilecompleted without errors.GET /V1/hellotext/catalog/stock: products 1 and 2 salable, unknown product 999 not salable.https://www.hellotext.cominfont-src.node --test(76 passed), the isolated PHP checks,composer validate.Storefront tracking was also checked on 1.0.0 (unchanged here): the bridge starts, the SDK initializes, and
cart.addedreacheshttps://api.hellotext.com/v1/track/eventswith HTTP 200.After merge
Tag
1.0.1so Packagist publishes it.