Repository navigation
magento-integration: add tests and ci to the module repo - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd3a19fa2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a57667279c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a576672 to
1434bbe
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Imports the standalone PHP and JavaScript checks and contributor tooling from
magento-internalonto currentmain. The copied tests now match SDK-owned sessions: tracked-link and cookie sessions are preserved, and Magento's deleted session-generation classes stay deleted. The translation check also identified two missing Spanish stock-error messages, which are included here.Test/Unit/Jsbridge tests..gitattributes; document the current local test commands.Local validation passed: 67 JavaScript tests, 17 standalone PHP scripts on PHP 8.3, and 62 PHPUnit tests with 250 assertions against Magento 2.4.7-p10. PHP/PHTML lint, XML parsing, Composer validation, the configured coding-standard check, and release archive checks also passed.
The internal
dev/acceptance harness, its four tests, and internal documentation are outside this import. A live storefront smoke test is still required for installation and browser behavior.