[markovejnovic]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 92.05637% with 124 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
native/suidhelper/src/fs/path.rs	82.14%	20 Missing ⚠️
native/suidhelper/src/linux/cgroup/mod.rs	83.05%	20 Missing ⚠️
native/suidhelper/src/linux/loopdev.rs	81.25%	18 Missing ⚠️
native/suidhelper/src/process/privilege.rs	88.18%	13 Missing ⚠️
native/suidhelper/src/fs/dir.rs	84.31%	8 Missing ⚠️
native/suidhelper/src/process/binary.rs	84.21%	6 Missing ⚠️
...ve/suidhelper/src/tools/network/teardown_orphan.rs	0.00%	6 Missing ⚠️
native/suidhelper/src/util/chroot_jail.rs	81.81%	6 Missing ⚠️
native/suidhelper/src/fs/dev.rs	75.00%	3 Missing ⚠️
native/suidhelper/src/linux/cgroup/events.rs	95.52%	3 Missing ⚠️
... and 11 more

📢 Thoughts on this report? Let us know!

[github-actions]

Test Results

    3 files   - 1  225 suites   - 4   4m 21s ⏱️ + 1m 6s
  686 tests +5  683 ✅ +2    3 💤 +3  0 ❌ ±0 
1 166 runs  +2  683 ✅ +2  483 💤 ±0  0 ❌ ±0 

Results for commit 536325e. ± Comparison against base commit 3e08010.

This pull request removes 45 and adds 50 tests. Note that renamed tests count towards both.

hyper-suidhelper::e2e_argv ‑ blockdev_getsz_argv_and_parse_as_root
hyper-suidhelper::e2e_argv ‑ losetup_list_argv_and_parse_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_attach_passes_validated_fd_readonly_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_attach_refuses_out_of_base_before_running_tool_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_attach_rw_omits_read_only_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_child_failure_surfaces_its_stderr_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_detach_argv_and_parse_as_root
hyper-suidhelper::e2e_losetup ‑ losetup_detach_refuses_non_loop_operands_as_root
hyper-suidhelper::safe_dev ‑ blockdev_accepts_hyper_dm
hyper-suidhelper::safe_dev ‑ blockdev_accepts_loop
…

Elixir.Hyper.SuidHelper.DmsetupPropertiesTest ‑ property linear_table maps the whole origin from offset 0
hyper-suidhelper ‑ linux::cgroup::events::tests::a_missing_or_non_boolean_flag_is_malformed
hyper-suidhelper ‑ linux::cgroup::events::tests::every_read_reflects_the_current_contents
hyper-suidhelper ‑ linux::cgroup::events::tests::non_utf8_contents_are_an_error
hyper-suidhelper ‑ linux::cgroup::events::tests::reads_exactly_the_populated_and_frozen_flags
hyper-suidhelper ‑ linux::cgroup::tests::a_populated_cgroup_is_only_removable_after_kill_procs_as_root
hyper-suidhelper ‑ linux::cgroup::tests::kill_procs_and_remove_succeed_once_the_cgroup_is_gone_as_root
hyper-suidhelper ‑ linux::cgroup::tests::open_refuses_a_directory_that_is_not_on_cgroup2
hyper-suidhelper ‑ linux::dm::name::tests::rejects_a_leading_dash
hyper-suidhelper ‑ linux::dm::name::tests::rejects_any_byte_outside_the_charset
…

♻️ This comment has been updated with latest results.