Skip to content

Disable failing node.js CI workflow - #983

Merged
janekhuong merged 2 commits into
devfrom
fix/failing-nodejs-ci
Oct 29, 2026
Merged

janekhuong merged 2 commits into
devfrom
fix/failing-nodejs-ci

Conversation

@mfsohail12

@mfsohail12 mfsohail12 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
  • Removed package-lock.json from .gitignore as it doesn't need to be ignored
  • Manually disabled and commented out the node.js CI workflow defined in node.js.yml as it runs tests that haven't been updated in ~6-8 years

closes #946

@mfsohail12 mfsohail12 changed the title Fix/failing nodejs ci Disable failing node.js CI workflow Oct 29, 2026
@mfsohail12
mfsohail12 marked this pull request as ready for review October 29, 2026 02:33
@mfsohail12
mfsohail12 requested a review from janekhuong October 29, 2026 02:34

@janekhuong janekhuong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@janekhuong
janekhuong merged commit 716ede0 into dev Oct 29, 2026
@janekhuong
janekhuong deleted the fix/failing-nodejs-ci branch October 29, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm test always fails - build/merge requirement

2 participants