Skip to content

fix(pack): remove ROCm 10 image inspection gate - #415

Merged
thxCode merged 2 commits into
mainfrom
fix/rocm-postpack-inspection
Nov 5, 2026
Merged

thxCode merged 2 commits into
mainfrom
fix/rocm-postpack-inspection

Conversation

@thxCode

@thxCode thxCode commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

ROCm 10 Pack run 41952538686 was blocked by the newly added end-of-build inspection. Remove that ROCm 10-specific inspection from image production and analyze the published image separately on a Linux amd64 Docker host.

  • Remove the recipe's final inspection invocation and delete pack/rocm/check_vllm.py.
  • Delete the package/SDK/native-loader tests that only exercised that script.
  • Keep the compiler-target tests, runtime matrix coverage, and Ray/CuPy dependency regression.
  • Replace the script-specific documentation with digest-based post-publication inspection guidance.

The existing LMCache ABI check and Pack's digest-bound dependency collection remain in place.

Validation: full pytest with the pinned auto-sync tools passed on macOS (1334 passed, 17 skipped). The retained compiler-target, Ray/CuPy resolver, and recipe/matrix selection tests passed (72 focused tests). All-file hooks, Python distribution build, and strict MkDocs passed.

After merge, start a new Pack invocation from the updated source. Published-image analysis and GPU validation remain pending.

Relates #413 and #414.

Signed-off-by: thxCode <thxcode0824@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request shifts the ROCm vLLM image verification gate from a build-time step inside the Dockerfile to an optional post-publish inspection. It updates the documentation with instructions on how to run the check_vllm.py script against a published image, adjusts the script to import onnxruntime before loading its ROCm provider to ensure proper initialization, and introduces a new test suite (test_rocm_native_loading.py) to verify native library loading and symbol resolution. Obsolete build-gate tests have been removed. I have no feedback to provide as there are no review comments.

Signed-off-by: thxCode <thxcode0824@gmail.com>
@thxCode thxCode changed the title fix(pack): move ROCm inspection out of image builds fix(pack): remove ROCm 10 image inspection gate Nov 5, 2026
@thxCode
thxCode merged commit d6da263 into main Nov 5, 2026
8 checks passed
@thxCode
thxCode deleted the fix/rocm-postpack-inspection branch November 5, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant