Repository navigation
fix(pack): remove ROCm 10 image inspection gate - #415
Merged
Merged
Conversation
Signed-off-by: thxCode <thxcode0824@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request shifts the ROCm vLLM image verification gate from a build-time step inside the Dockerfile to an optional post-publish inspection. It updates the documentation with instructions on how to run the check_vllm.py script against a published image, adjusts the script to import onnxruntime before loading its ROCm provider to ensure proper initialization, and introduces a new test suite (test_rocm_native_loading.py) to verify native library loading and symbol resolution. Obsolete build-gate tests have been removed. I have no feedback to provide as there are no review comments.
Signed-off-by: thxCode <thxcode0824@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCm 10 Pack run 41952538686 was blocked by the newly added end-of-build inspection. Remove that ROCm 10-specific inspection from image production and analyze the published image separately on a Linux amd64 Docker host.
pack/rocm/check_vllm.py.The existing LMCache ABI check and Pack's digest-bound dependency collection remain in place.
Validation: full pytest with the pinned auto-sync tools passed on macOS (1334 passed, 17 skipped). The retained compiler-target, Ray/CuPy resolver, and recipe/matrix selection tests passed (72 focused tests). All-file hooks, Python distribution build, and strict MkDocs passed.
After merge, start a new Pack invocation from the updated source. Published-image analysis and GPU validation remain pending.
Relates #413 and #414.