Repository navigation
fix(runner): preserve platform dependencies and ascend pd transfers - #402
Merged
thxCode merged 2 commits intoNov 5, 2026
Merged
Conversation
Signed-off-by: yxf <xf.ye@gpustack.ai>
This was referenced Nov 2, 2026
Merged
There was a problem hiding this comment.
Code Review
This pull request introduces a new build stage in the CANN Dockerfile to rebuild the HIXL host library, applies patches to both HIXL and vllm-ascend, and updates the runner to preserve platform dependencies. It also adds comprehensive tests for these changes. The review feedback highlights a few key areas for improvement: safeguarding against a potential AttributeError in the mooncake connector patch, using std::chrono::steady_clock instead of system_clock to guarantee monotonic channel IDs, and ensuring that tests gracefully skip if the system patch utility is not available.
- Resolve Mooncake peer endpoints by absolute handshake ports across data parallel groups. - Rebuild the HIXL host library with generation counters for surviving remote clients. - Verify patch application and skip native regression tests when required tools are unavailable. Signed-off-by: yxf <xf.ye@gpustack.ai>
yxf0314
force-pushed
the
issue/5742-preserve-runner-dependencies
branch
from
November 5, 2026 08:56
5d08434 to
b54ccfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref gpustack/gpustack#5742.
Merge order: merge GPUStack backend #6631 first, then UI #1511 and this Runner PR. Publish the updated Runner package and latest 0.30.0 images through the normal release workflow afterward.
Validation: