Skip to content

fix(runner): preserve platform dependencies and ascend pd transfers - #402

Merged
thxCode merged 2 commits into
gpustack:mainfrom
yxf0314:issue/5742-preserve-runner-dependencies
Nov 5, 2026
Merged

thxCode merged 2 commits into
gpustack:mainfrom
yxf0314:issue/5742-preserve-runner-dependencies

Conversation

@yxf0314

@yxf0314 yxf0314 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Ref gpustack/gpustack#5742.

Merge order: merge GPUStack backend #6631 first, then UI #1511 and this Runner PR. Publish the updated Runner package and latest 0.30.0 images through the normal release workflow afterward.

  • Preserve measured per-platform dependency metadata when grouping backend/service runners, including the distinction between unknown and empty metadata.
  • Patch vLLM-Ascend Mooncake peer address lookup for explicit DP rank endpoints.
  • Rebuild only the HIXL host library with process-generation channel IDs so a restarted Prefill peer does not reuse channel names still held by Decode. Skip the HIXL stage on 310P.
  • Apply these recipe changes to the latest 0.30.0 image; no post-operation is added for older images.

Validation:

  • 163 related tests passed and scoped hooks passed.
  • The connector patch applies without fuzz to official vLLM-Ascend v0.30.0 source.
  • On the earlier CANN 9.2.0/0.30.0-rc2 baseline, the HIXL host stage built successfully; isolated transfer reproduction and real cross-host PD tests passed through two Prefill-only recovery cycles while Decode/Router stayed running.
  • The rebased recipe uses upstream's CANN 9.2.1/stable 0.30.0 base. That final base has not been hardware-retested, and no complete production image has been built or published in this step. The HIXL source pin remains 9.2.0 and requires ABI/runtime verification on the final base.

Signed-off-by: yxf <xf.ye@gpustack.ai>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new build stage in the CANN Dockerfile to rebuild the HIXL host library, applies patches to both HIXL and vllm-ascend, and updates the runner to preserve platform dependencies. It also adds comprehensive tests for these changes. The review feedback highlights a few key areas for improvement: safeguarding against a potential AttributeError in the mooncake connector patch, using std::chrono::steady_clock instead of system_clock to guarantee monotonic channel IDs, and ensuring that tests gracefully skip if the system patch utility is not available.

Comment thread tests/pack/test_dockerfile_selection.py Resolved
Comment thread tests/pack/test_dockerfile_selection.py Resolved
- Resolve Mooncake peer endpoints by absolute handshake ports across data parallel groups.
- Rebuild the HIXL host library with generation counters for surviving remote clients.
- Verify patch application and skip native regression tests when required tools are unavailable.

Signed-off-by: yxf <xf.ye@gpustack.ai>
@yxf0314
yxf0314 force-pushed the issue/5742-preserve-runner-dependencies branch from 5d08434 to b54ccfe Compare November 5, 2026 08:56
@yxf0314
yxf0314 requested a review from thxCode November 5, 2026 09:09

@thxCode thxCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thxCode
thxCode merged commit 97b11c5 into gpustack:main Nov 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants