Repository navigation
Don't split escaped backslashes when reflowing long string literals. - #1513
Merged
Merged
Conversation
When splitting a long string literal, `StringWrapper` looked for `\t`, `\n` and `\r` escapes at every position in the literal's source, without tracking whether the backslash was itself escaped. So an escaped backslash followed by `t`, `n` or `r` (for example `\\t` in a Windows path or a regular expression) was split between the two backslashes, producing an unterminated string literal or a string with different contents. The safety check after wrapping then rejected the change, and formatting failed with an error. `StringWrapper` now skips over each escape sequence as a unit, so only real escapes are treated as places to split. Fixes #1186 Fixes #1253 Fixes #1439 PiperOrigin-RevId: 1010274507
copybara-service
Bot
force-pushed
the
test_1009611290
branch
from
October 30, 2026 06:59
cd1597a to
7e4696d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't split escaped backslashes when reflowing long string literals.
When splitting a long string literal,
StringWrapperlooked for\t,\nand\rescapes at every position in the literal's source, without tracking whether the backslash was itself escaped. So an escaped backslash followed byt,norr(for example\\tin a Windows path or a regular expression) was split between the two backslashes, producing an unterminated string literal or a string with different contents. The safety check after wrapping then rejected the change, and formatting failed with an error.StringWrappernow skips over each escape sequence as a unit, so only real escapes are treated as places to split.Fixes #1186
Fixes #1253
Fixes #1439