Repository navigation
Optimize Operator WebUI layout, spacing and drag/resize UX - #3327
Merged
Merged
Conversation
adelva1984
force-pushed
the
optimize-webui-view-pane
branch
from
October 20, 2026 17:35
1d366d5 to
4905cae
Compare
adelva1984
enabled auto-merge
October 20, 2026 17:35
0405ysj
removed their request for review
October 21, 2026 00:58
Collaborator
|
Reassigned to @k311093 who has detailed sight around webui layout. |
k311093
force-pushed
the
optimize-webui-view-pane
branch
from
October 21, 2026 05:54
4905cae to
0a67380
Compare
Remove empty vertical space below device UI by updating totalHorizontalSpacing to count all horizontal elements widths. Fix resizing getting stuck when entering the device UI by disabling pointer-events on inner iframes while resizing. Fix overflow on ktd-grid from margin by setting width to auto. Fix resizing border drifting at larger device UI sizes by setting a fixed padding. This also simplifies computing totalHorizontalSpacing. Prevent device UI close (X) button drifting at larger UI sizes by setting a fixed position relative to its parent. Add cursor grab and grabbing styling when hovering over the device UI top bar, and when dragging it. Bug: 571863643 Test: Verified phone (portrait) and tablet (landscape) UI, resized device UI, verified resizing does not freeze, dragged devices from the top bar
adelva1984
force-pushed
the
optimize-webui-view-pane
branch
from
October 21, 2026 18:07
0a67380 to
c44bb37
Compare
Collaborator
|
Thanks for the contribution! Looks good to me. |
k311093
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove empty vertical space below device UI by updating totalHorizontalSpacing to count all horizontal elements widths.
Fix resizing getting stuck when entering the device UI by disabling pointer-events on inner iframes while resizing.
Fix overflow on ktd-grid from margin by setting width to auto.
Fix resizing border drifting at larger device UI sizes by setting a fixed padding. This also simplifies computing totalHorizontalSpacing.
Prevent device UI close (X) button drifting at larger UI sizes by setting a fixed position relative to its parent.
Add cursor grab and grabbing styling when hovering over the device UI top bar, and when dragging it.
Bug: 571863643
Test: Verified phone (portrait) and tablet (landscape) UI, resized
device UI, verified resizing does not freeze, dragged devices from the
top bar