Skip to content

Support returning a Result the callback in HttpClient::DownloadToCallback - #3324

Merged
rmuthiah merged 3 commits into
google:mainfrom
Databean:http_client_callback_result
Oct 23, 2026
Merged

rmuthiah merged 3 commits into
google:mainfrom
Databean:http_client_callback_result

Conversation

@Databean

@Databean Databean commented Oct 9, 2026

Copy link
Copy Markdown
Member

Currently callback implementations can only log errors.

Bug: b/571708640

@Databean
Databean force-pushed the http_client_callback_result branch from 05112de to c460481 Compare October 9, 2026 02:21
@Databean
Databean requested a review from jemoreira October 13, 2026 20:51
@Databean
Databean force-pushed the http_client_callback_result branch from c460481 to a2aa787 Compare October 13, 2026 20:51
@rmuthiah rmuthiah added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Oct 15, 2026
@rmuthiah
rmuthiah force-pushed the http_client_callback_result branch from a2aa787 to 9ee1805 Compare October 15, 2026 19:02
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Oct 15, 2026
@Databean
Databean force-pushed the http_client_callback_result branch from 9ee1805 to a8cd30d Compare October 17, 2026 16:08
@rmuthiah
rmuthiah force-pushed the http_client_callback_result branch from a8cd30d to caea679 Compare October 19, 2026 21:18
@rmuthiah rmuthiah added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Oct 20, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Oct 20, 2026
@Databean
Databean added this pull request to the merge queue Oct 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2026
@rmuthiah
rmuthiah added this pull request to the merge queue Oct 23, 2026
Merged via the queue into google:main with commit 22ca1fc Oct 23, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants